wip(api): normalize snake_case/camelCase in passthrough methods to boto. #338
Draft
Hweinstock wants to merge 2 commits intoaws:mainfrom
Draft
wip(api): normalize snake_case/camelCase in passthrough methods to boto. #338Hweinstock wants to merge 2 commits intoaws:mainfrom
Hweinstock wants to merge 2 commits intoaws:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage ? 90.96%
=======================================
Files ? 44
Lines ? 4096
Branches ? 628
=======================================
Hits ? 3726
Misses ? 203
Partials ? 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
built on #335
*Issue #, if available:*#336
Description of changes:
Problem
MemoryClient and MemorySessionManager expose some methods via
__getattr__passthrough to boto3, which requires camelCase kwargs (memoryId, clientToken), while explicit SDK methods accept snake_case (memory_id,client_token). Users have no way to know which convention to use without reading the source.
See attached issue for an example.
Solution
camelCasestill works (backward compat), snake_case is converted to camelCase before forwarding to boto3.Follows the existing
__getattr__pattern — no new public API surface.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.