Skip to content

feat: add data plane, extraction, and lifecycle integ tests to TestMemoryClient#334

Merged
Hweinstock merged 1 commit intoaws:mainfrom
Hweinstock:integ-test/rewrite-memory-client
Mar 13, 2026
Merged

feat: add data plane, extraction, and lifecycle integ tests to TestMemoryClient#334
Hweinstock merged 1 commit intoaws:mainfrom
Hweinstock:integ-test/rewrite-memory-client

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Mar 12, 2026

Issue #, if available: #316

Description of changes:

Problem

TestMemoryClient only had stream delivery tests. Data plane, retrieval, and lifecycle operations had no pytest coverage.

Solution

  • Extended TestMemoryClient with data plane (1-10), retrieval (11-15), and lifecycle (16-18) tests.
  • Retrieval tests use a pre-populated memory (MEMORY_PREPOPULATED_ID env var) to test retrieve_memories across
    semantic, preference, and summary namespaces plus prefix matching and wildcard rejection — to avoid flaky extraction timing.

Other tiny fixes included:

  • fix include path in pyproject.toml to avoid ruff errors.
  • remove duplicate dependency.

Testing

  • passed in dev account ~8.5 min.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Hweinstock Hweinstock force-pushed the integ-test/rewrite-memory-client branch 2 times, most recently from 660bc1d to 738b3da Compare March 12, 2026 20:28
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@11e2ac5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage        ?   90.85%           
=======================================
  Files           ?       42           
  Lines           ?     4046           
  Branches        ?      624           
=======================================
  Hits            ?     3676           
  Misses          ?      203           
  Partials        ?      167           
Flag Coverage Δ
unittests 90.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hweinstock Hweinstock force-pushed the integ-test/rewrite-memory-client branch from 738b3da to 16244f5 Compare March 12, 2026 20:35
@Hweinstock Hweinstock force-pushed the integ-test/rewrite-memory-client branch 5 times, most recently from 7fef515 to b05644a Compare March 13, 2026 12:00
@Hweinstock Hweinstock force-pushed the integ-test/rewrite-memory-client branch from b05644a to eab881a Compare March 13, 2026 13:42
@Hweinstock Hweinstock marked this pull request as ready for review March 13, 2026 14:08
@Hweinstock Hweinstock requested a review from a team March 13, 2026 14:08
@Hweinstock Hweinstock merged commit 62fdc9a into aws:main Mar 13, 2026
17 of 18 checks passed
@Hweinstock Hweinstock deleted the integ-test/rewrite-memory-client branch March 13, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants