feat(sqla-core): Add support for rendering Database Specific queries #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 79.81% 79.89% +0.07%
==========================================
Files 84 84
Lines 3305 3308 +3
==========================================
+ Hits 2638 2643 +5
+ Misses 667 665 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I'll restructure this PR after the sqla 1.4 PR is merged, as our test restructures will conflict pretty heavily |
Contributor
|
@cybojenix Thanks. I'll take a look once it is ready. :) |
Contributor
Author
|
Over to you, @srprash |
srprash
reviewed
Apr 28, 2021
Contributor
srprash
left a comment
srprash
left a comment
There was a problem hiding this comment.
Just a minor comment. Otherwise LGTM! Thanks!
Contributor
|
And could you also update the branch? Thanks! |
by default it runs 9.4. We need to use a feature added in 9.5
This makes the sqla-core plugin aware of how to compile a database specific query. It seems in some cases, we see strings come through (mostly pragma calls when doing 'create_all'), so do a check to see if the object looks like a SQL Expression object. Fixes: #290
this reduces duplication of the Engine fixture.
Contributor
Author
|
Both addressed |
Contributor
|
Awesome! thanks |
srprash
approved these changes
Apr 28, 2021
Hargrav3s
pushed a commit
to Gavant/aws-xray-sdk-python
that referenced
this pull request
Mar 22, 2022
…ws#291) * chore(sqla_core): setup an area to run postgres tests * fix: run a supported version of postgres in travis by default it runs 9.4. We need to use a feature added in 9.5 * feat(sqla-core): Add support for rendering Database Specific queries This makes the sqla-core plugin aware of how to compile a database specific query. It seems in some cases, we see strings come through (mostly pragma calls when doing 'create_all'), so do a check to see if the object looks like a SQL Expression object. Fixes: aws#290 * fix: remove a spurious 'self' in the fixtures * chore: make the DB URL injectable this reduces duplication of the Engine fixture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #290
Description of changes:
This makes the sqla-core plugin aware of how to compile a database specific query.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
fixes: #290