Skip to content

fix: prevent command injection in release workflow #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukeina2z merged 2 commits into from
Nov 10, 2025
Merged

fix: prevent command injection in release workflow #442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff54a99
fix: prevent command injection in release workflow
lukeina2z Nov 7, 2025
3342caa
address code review feedback.
lukeina2z Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,22 @@ jobs:
with:
path: ~/.gradle/wrapper
key: gradle-wrapper-${{ hashFiles('gradle/wrapper/gradle-wrapper.properties') }}
- name: Validate version input
run: |
if [[ ! "${{ github.event.inputs.version }}" =~ ^[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?(\+[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?$ ]]; then
echo "Invalid version format. Must follow Semantic Versioning (e.g., 1.2.3, 1.2.3-alpha.1, 1.2.3+build.1)"
exit 1
fi
- name: Build and test
run: ./gradlew build -Prelease.version=${{ github.event.inputs.version }} --stacktrace
run: ./gradlew build -Prelease.version="$RELEASE_VERSION" --stacktrace
env:
CI: true
RELEASE_VERSION: ${{ github.event.inputs.version }}
- name: Build and publish to sonatype
run: ./gradlew final closeAndReleaseSonatypeStagingRepository -Prelease.version=${{ github.event.inputs.version }} --stacktrace
run: ./gradlew final closeAndReleaseSonatypeStagingRepository -Prelease.version="$RELEASE_VERSION" --stacktrace
env:
CI: true
RELEASE_VERSION: ${{ github.event.inputs.version }}
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
GPG_KEY_ID: ${{ secrets.GPG_KEY_ID }}
Expand Down