Allow selecting AWS SDK TLS features#197
Conversation
|
This looks ok to me at first glance. Can you elaborate on your use case? |
Signed-off-by: Simon Marty <martysi@amazon.com>
Signed-off-by: Simon Marty <simon.marty@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 14 14
Lines 2405 2405
Branches 2405 2405
=======================================
Hits 2216 2216
Misses 143 143
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @simonmarty, thanks for asking. My main use case is dependency-tree control for applications that explicitly manage the AWS SDK HTTP/TLS stack. In our application, we want to use the SDK This matters because enabling At the moment, we need to keep temporary With this PR, existing users keep the current default behavior, while downstream applications can opt out explicitly by using For this TLS-selection use case, the following example should be enough: aws_secretsmanager_caching = { version = "2", default-features = false, features = [
"default-https-client",
"rt-tokio",
] }If an application relies on AWS profiles that use SSO or |
Description
Why is this change being made?
What is changing?
default-https-client,rt-tokio,credentials-process,sso, andrustlsfeatures.aws_secretsmanager_cachingwithdefault-features = falseand the modern HTTPS client feature set.Related Links
Testing
How was this tested?
cargo check -p aws_secretsmanager_cachingcargo check -p aws_secretsmanager_caching --all-featurescargo check -p aws_secretsmanager_caching --no-default-features --features default-https-client,rt-tokio,credentials-process,ssocargo test -p aws_secretsmanager_caching --no-fail-fastcargo test -p aws_secretsmanager_caching --no-default-features --features default-https-client,rt-tokio,credentials-process,sso --no-fail-fastWhen testing locally, provide testing artifact(s):
unused_parenswarnings in tests are still present.Reviewee Checklist
Update the checklist after submitting the PR
If not, why:
If not, why:
If not, why:
If not, why: Not run locally.
If not, why: Not run locally.
If not, why: Not needed; this only changes Cargo feature wiring and README docs.
If not, why:
If not, why: Not needed; no runtime logic was added.
If not, why:
If not, why: No breaking changes. Default features are kept unchanged.
Reviewer Checklist
All reviewers please ensure the following are true before reviewing: