Skip to content

issue: Fix SSO OIDC error messaging #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sichanyoo merged 3 commits into from
May 11, 2026
+23 −1
Merged

issue: Fix SSO OIDC error messaging #3378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eab6b2f
Add handling for oauth2.0 error_description field for SSO OIDC by add…
May 11, 2026
f724273
Merge branch 'version-3' into issue/fix-ssooidc-errors
May 11, 2026
dea4e64
Comment in deserializer change & CHANGELOG
May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gems/aws-sdk-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Unreleased Changes
------------------
* Feature - Add YJIT & ZJIT tracking to user agent.
* Issue - Fix error messaging in SSO OIDC.

3.246.0 (2026-04-23)
------------------
Expand Down
3 changes: 2 additions & 1 deletion gems/aws-sdk-core/lib/aws-sdk-core/json/error_handler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ def error_message(code, json)
if code == 'RequestEntityTooLarge'
'Request body must be less than 1 MB'
else
json['message'] || json['Message'] || ''
# SSO OIDC returns error message in error_description, following OAuth 2.0 spec.
json['message'] || json['Message'] || json['error_description'] || ''
end
end

Expand Down
20 changes: 20 additions & 0 deletions gems/aws-sdk-core/spec/aws/json/error_handler_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,26 @@ module Json
}
JSON

let(:oauth2_error_resp) { <<~JSON.strip }
{
"__type":"Oauth2ErrorResponse",
"error_description":"foo"
}
JSON

it 'extracts oauth2 error message from error_description' do
client.stub_responses(
:batch_get_item,
{ status_code: 400, body: oauth2_error_resp, headers: {} }
)

expect { client.batch_get_item(request_items: {}) }
.to raise_error do |e|
expect(e.code).to eq('Oauth2ErrorResponse')
expect(e.message).to eq('foo')
end
end

it 'extracts error data' do
client.stub_responses(
:batch_get_item,
Expand Down
Loading