chore(codegen): remove checks for deprecated SetShape #7403
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Dec 8, 2025
| @Override | ||
| public final String setShape(SetShape shape) { | ||
| return getDelegateDeserializer(shape); | ||
| } |
Contributor
There was a problem hiding this comment.
if we decide we're not supporting sets, this method and all other code points where sets were handled should throw an error, rather than allow the customer to get possibly non-functional code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
aws-sdk-js-v3/codegen/sdk-codegen/aws-models/dsql.json
Lines 126 to 135 in ff5b376
Description
Remove checks for deprecated SetShape
Testing
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.