Skip to content

Fix NPE in DoubleAttributeConverter and FloatAttributeConverter for null input #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
S-Saranya1 wants to merge 3 commits into
base: master
Choose a base branch
from
+15 −0
Open

Fix NPE in DoubleAttributeConverter and FloatAttributeConverter for null input #6782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f6468e
Fix NPE in DoubleAttributeConverter and FloatAttributeConverter for n…
S-Saranya1 Mar 11, 2026
9a1f1e8
Fix NPE in DoubleAttributeConverter and FloatAttributeConverter for n…
S-Saranya1 Mar 11, 2026
20eed83
Add null validation in ConverterUtils.validateDouble/validateFloat to…
S-Saranya1 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/bugfix-AmazonDynamoDBEnhancedClient-192189d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "Amazon DynamoDB Enhanced Client",
"contributor": "",
"description": "Fix NullPointerException in `DoubleAttributeConverter` and `FloatAttributeConverter` when input is null. Fixes [#6639](https://github.com/aws/aws-sdk-java-v2/issues/6639)."
}
2 changes: 2 additions & 0 deletions ...main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ private ConverterUtils() {
* @param input
*/
public static void validateDouble(Double input) {
Validate.paramNotNull(input, "input");
Validate.isTrue(!Double.isNaN(input), "NaN is not supported by the default converters.");
Validate.isTrue(Double.isFinite(input), "Infinite numbers are not supported by the default converters.");
}
Expand All @@ -48,6 +49,7 @@ public static void validateDouble(Double input) {
* @param input
*/
public static void validateFloat(Float input) {
Validate.paramNotNull(input, "input");
Validate.isTrue(!Float.isNaN(input), "NaN is not supported by the default converters.");
Validate.isTrue(Float.isFinite(input), "Infinite numbers are not supported by the default converters.");
}
Expand Down
7 changes: 7 additions & 0 deletions ...e/amazon/awssdk/enhanced/dynamodb/converters/attribute/NumberAttributeConvertersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package software.amazon.awssdk.enhanced.dynamodb.converters.attribute;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.data.Offset.offset;
import static software.amazon.awssdk.enhanced.dynamodb.converters.attribute.ConverterTestUtils.assertFails;
import static software.amazon.awssdk.enhanced.dynamodb.converters.attribute.ConverterTestUtils.transformFrom;
Expand Down Expand Up @@ -150,6 +151,9 @@ public void floatAttributeConverterBehaves() {
assertFails(() -> transformFrom(converter, Float.NEGATIVE_INFINITY));
assertFails(() -> transformFrom(converter, Float.POSITIVE_INFINITY));
assertFails(() -> transformFrom(converter, Float.NaN));
assertThatThrownBy(() -> transformFrom(converter, null))
.isInstanceOf(NullPointerException.class)
.hasMessageContaining("input must not be null");

assertThat(transformFrom(converter, -Float.MAX_VALUE).n()).isEqualTo("-3.4028235E38");
assertThat(Float.parseFloat(transformFrom(converter, -42.42f).n())).isCloseTo(-42.42f, offset(1E-10f));
Expand Down Expand Up @@ -179,6 +183,9 @@ public void doubleAttributeConverterBehaves() {
assertFails(() -> transformFrom(converter, Double.NEGATIVE_INFINITY));
assertFails(() -> transformFrom(converter, Double.POSITIVE_INFINITY));
assertFails(() -> transformFrom(converter, Double.NaN));
assertThatThrownBy(() -> transformFrom(converter, null))
.isInstanceOf(NullPointerException.class)
.hasMessageContaining("input must not be null");

assertThat(transformFrom(converter, -Double.MAX_VALUE).n()).isEqualTo("-1.7976931348623157E308");
assertThat(Double.parseDouble(transformFrom(converter, -42.42d).n())).isCloseTo(-42.42d, offset(1E-10));
Expand Down
Loading