Skip to content

Fix race in AsyncWaiter#3762

Open
pulimsr wants to merge 1 commit intomainfrom
pr/3755-fix-race-asyncwaiter
Open

Fix race in AsyncWaiter#3762
pulimsr wants to merge 1 commit intomainfrom
pr/3755-fix-race-asyncwaiter

Conversation

@pulimsr
Copy link
Contributor

@pulimsr pulimsr commented Mar 25, 2026

Issue #3755

Fixes a race condition in AsyncWaiter::Wakeup() in CRTHttpClient.cpp — moves notify_one() inside the lock guard to prevent a race between the notification and destruction of the stack-local condvar. Verified with Clang TSAN on Amazon Linux 2023.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Mikhail Kornaukhov <mkornaukhov@serenedb.com>
@pulimsr pulimsr mentioned this pull request Mar 25, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants