Skip to content

Explicit construct outcomes on client operations #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbaluja wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Explicit construct outcomes on client operations #3760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44bd41a
Update operation templates to explicitly construct rather than rely o…
sbaluja Mar 24, 2026
850cdbb
Updated clients with explicit outcomes
sbaluja Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
127 changes: 85 additions & 42 deletions generated/src/aws-cpp-sdk-AWSMigrationHub/source/MigrationHubClient.cpp
View file
Open in desktop

Large diffs are not rendered by default.

192 changes: 118 additions & 74 deletions generated/src/aws-cpp-sdk-accessanalyzer/source/AccessAnalyzerClient.cpp
View file
Open in desktop

Large diffs are not rendered by default.

85 changes: 55 additions & 30 deletions generated/src/aws-cpp-sdk-account/source/AccountClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,10 @@ AcceptPrimaryEmailUpdateOutcome AccountClient::AcceptPrimaryEmailUpdate(const Ac
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, AcceptPrimaryEmailUpdate, CoreErrors,
CoreErrors::ENDPOINT_RESOLUTION_FAILURE, endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/acceptPrimaryEmailUpdate");
return AcceptPrimaryEmailUpdateOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess() ? AcceptPrimaryEmailUpdateOutcome(AcceptPrimaryEmailUpdateResult(result.GetResultWithOwnership()))
: AcceptPrimaryEmailUpdateOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -203,8 +205,9 @@ DeleteAlternateContactOutcome AccountClient::DeleteAlternateContact(const Delete
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, DeleteAlternateContact, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/deleteAlternateContact");
return DeleteAlternateContactOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return DeleteAlternateContactOutcome(result);
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -233,8 +236,9 @@ DisableRegionOutcome AccountClient::DisableRegion(const DisableRegionRequest& re
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, DisableRegion, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/disableRegion");
return DisableRegionOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return DisableRegionOutcome(result);
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -263,8 +267,9 @@ EnableRegionOutcome AccountClient::EnableRegion(const EnableRegionRequest& reque
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, EnableRegion, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/enableRegion");
return EnableRegionOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return EnableRegionOutcome(result);
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -293,8 +298,10 @@ GetAccountInformationOutcome AccountClient::GetAccountInformation(const GetAccou
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, GetAccountInformation, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/getAccountInformation");
return GetAccountInformationOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess() ? GetAccountInformationOutcome(GetAccountInformationResult(result.GetResultWithOwnership()))
: GetAccountInformationOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -323,8 +330,10 @@ GetAlternateContactOutcome AccountClient::GetAlternateContact(const GetAlternate
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, GetAlternateContact, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/getAlternateContact");
return GetAlternateContactOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess() ? GetAlternateContactOutcome(GetAlternateContactResult(result.GetResultWithOwnership()))
: GetAlternateContactOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -353,8 +362,10 @@ GetContactInformationOutcome AccountClient::GetContactInformation(const GetConta
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, GetContactInformation, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/getContactInformation");
return GetContactInformationOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess() ? GetContactInformationOutcome(GetContactInformationResult(result.GetResultWithOwnership()))
: GetContactInformationOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -384,8 +395,11 @@ GetGovCloudAccountInformationOutcome AccountClient::GetGovCloudAccountInformatio
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, GetGovCloudAccountInformation, CoreErrors,
CoreErrors::ENDPOINT_RESOLUTION_FAILURE, endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/getGovCloudAccountInformation");
return GetGovCloudAccountInformationOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess()
? GetGovCloudAccountInformationOutcome(GetGovCloudAccountInformationResult(result.GetResultWithOwnership()))
: GetGovCloudAccountInformationOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -414,8 +428,10 @@ GetPrimaryEmailOutcome AccountClient::GetPrimaryEmail(const GetPrimaryEmailReque
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, GetPrimaryEmail, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/getPrimaryEmail");
return GetPrimaryEmailOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess() ? GetPrimaryEmailOutcome(GetPrimaryEmailResult(result.GetResultWithOwnership()))
: GetPrimaryEmailOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -444,8 +460,10 @@ GetRegionOptStatusOutcome AccountClient::GetRegionOptStatus(const GetRegionOptSt
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, GetRegionOptStatus, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/getRegionOptStatus");
return GetRegionOptStatusOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess() ? GetRegionOptStatusOutcome(GetRegionOptStatusResult(result.GetResultWithOwnership()))
: GetRegionOptStatusOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -474,8 +492,10 @@ ListRegionsOutcome AccountClient::ListRegions(const ListRegionsRequest& request)
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, ListRegions, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/listRegions");
return ListRegionsOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess() ? ListRegionsOutcome(ListRegionsResult(result.GetResultWithOwnership()))
: ListRegionsOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -504,8 +524,9 @@ PutAccountNameOutcome AccountClient::PutAccountName(const PutAccountNameRequest&
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, PutAccountName, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/putAccountName");
return PutAccountNameOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return PutAccountNameOutcome(result);
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -534,8 +555,9 @@ PutAlternateContactOutcome AccountClient::PutAlternateContact(const PutAlternate
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, PutAlternateContact, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/putAlternateContact");
return PutAlternateContactOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return PutAlternateContactOutcome(result);
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -564,8 +586,9 @@ PutContactInformationOutcome AccountClient::PutContactInformation(const PutConta
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, PutContactInformation, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/putContactInformation");
return PutContactInformationOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return PutContactInformationOutcome(result);
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down Expand Up @@ -594,8 +617,10 @@ StartPrimaryEmailUpdateOutcome AccountClient::StartPrimaryEmailUpdate(const Star
AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, StartPrimaryEmailUpdate, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());
endpointResolutionOutcome.GetResult().AddPathSegments("/startPrimaryEmailUpdate");
return StartPrimaryEmailUpdateOutcome(
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER));
auto result =
MakeRequest(request, endpointResolutionOutcome.GetResult(), Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::SIGV4_SIGNER);
return result.IsSuccess() ? StartPrimaryEmailUpdateOutcome(StartPrimaryEmailUpdateResult(result.GetResultWithOwnership()))
: StartPrimaryEmailUpdateOutcome(result.GetError());
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, request.GetServiceRequestName()},
Expand Down
Loading
Loading