Skip to content

Conversation

@sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Dec 9, 2025

Issue #, if available:

#3639

Description of changes:

We previous made a change #3643 to preserve the request lifetime of a request so that cancel request can run in parallel without lifetime issues. This change used a wait_for that times out at one minute then would crash. This is under the assumption that a cancel request must run in 1 minutes and waiting longer will crash. A customer is still seeing the crash which is indicative that they are running under strain, however we should run this in sync to prevent the lifetime issue all together. Running back of the napkin tests show that sync is actually faster so making this sync seems like the right thing to do.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review December 9, 2025 20:32
@sbiscigl sbiscigl force-pushed the cancel-crt-request-sync branch from 103bcbd to 5fb041a Compare December 9, 2025 21:34
@sbiscigl sbiscigl force-pushed the cancel-crt-request-sync branch from 5fb041a to b09cd08 Compare December 10, 2025 00:39
@sbiscigl sbiscigl merged commit 5d36383 into main Dec 10, 2025
5 checks passed
@sbiscigl sbiscigl deleted the cancel-crt-request-sync branch December 10, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants