make request cancel sync to avoid lifetime issues in CRT #3648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3639
Description of changes:
We previous made a change #3643 to preserve the request lifetime of a request so that cancel request can run in parallel without lifetime issues. This change used a
wait_forthat times out at one minute then would crash. This is under the assumption that a cancel request must run in 1 minutes and waiting longer will crash. A customer is still seeing the crash which is indicative that they are running under strain, however we should run this in sync to prevent the lifetime issue all together. Running back of the napkin tests show that sync is actually faster so making this sync seems like the right thing to do.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.