Skip to content

fix: add mount-with write for java25 tests #8579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seshubaws merged 5 commits into from
Jan 16, 2026
Merged

fix: add mount-with write for java25 tests #8579

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
191eab3
fix: add mount with WRITE for java25 tests
seshubaws Jan 15, 2026
2a2560c
don't mw write for maven
seshubaws Jan 15, 2026
9d2912b
linting
seshubaws Jan 15, 2026
bbe7d0e
fix maven check
seshubaws Jan 15, 2026
55bd729
maven fix
seshubaws Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/integration/buildcmd/build_integ_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
get_sam_command,
run_command_with_input,
)
from samcli.commands.build.utils import MountMode


LOG = logging.getLogger(__name__)
Expand Down Expand Up @@ -661,7 +662,14 @@ def _test_with_building_java(
self.skipTest(self.SKIP_ARM64_EARLIER_JAVA_TESTS)

overrides = self.get_override(runtime, code_path, architecture, "aws.example.Hello::myHandler")
cmdlist = self.get_command_list(use_container=use_container, parameter_overrides=overrides)
mount_with = (
MountMode.WRITE
if use_container and str(runtime).lower() == "java25" and self.USING_MAVEN_PATH not in code_path
else None
)
cmdlist = self.get_command_list(
use_container=use_container, parameter_overrides=overrides, mount_with=mount_with
)
cmdlist += ["--skip-pull-image"]
if code_path == self.USING_GRADLEW_PATH and use_container and IS_WINDOWS:
osutils.convert_to_unix_line_ending(os.path.join(self.test_data_path, self.USING_GRADLEW_PATH, "gradlew"))
Expand Down
Loading