Skip to content

Conversation

@vicheey
Copy link
Contributor

@vicheey vicheey commented Jan 13, 2026

Which issue(s) does this change fix?

Some of the test account do not have the necessary resources deployed to run LMI test succesfully.
We need to skip the tests for now if required resources are available yet.

Why is this change necessary?

We had this #8554 which skip all LMI test and need manual change to re-enable the test.

How does it address the issue?

Make the skip condition depend on each test account available stack.

What side effects does this change have?

No. All the test already skip.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vicheey vicheey marked this pull request as ready for review January 13, 2026 00:50
@vicheey vicheey requested a review from a team as a code owner January 13, 2026 00:50
valerena
valerena previously approved these changes Jan 13, 2026
@vicheey vicheey force-pushed the lmi-integ-test-skip branch from ad43111 to 64b9975 Compare January 13, 2026 18:26
@vicheey vicheey requested a review from valerena January 13, 2026 21:24
@vicheey
Copy link
Contributor Author

vicheey commented Jan 13, 2026

TODO:

@vicheey
Copy link
Contributor Author

vicheey commented Jan 15, 2026

Running new tests: Integration Tests · aws/aws-sam-cli@ff61763

@vicheey
Copy link
Contributor Author

vicheey commented Jan 16, 2026

Not do merge yet. Investigating test failures.

Test failure:

  • package-delete-deploy (docker):
FAILED tests/integration/delete/test_delete_command.py::TestDelete::test_delete_no_prompts_with_s3_prefix_present_zip_04_aws_appsync_functionconfiguration_yaml - timed out after 600 seconds
FAILED tests/integration/delete/test_delete_command.py::TestDelete::test_delete_no_prompts_with_s3_prefix_present_zip_04_aws_appsync_functionconfiguration_yaml - AssertionError: 1 != 0
  • sync (docker)
FAILED tests/integration/sync/test_sync_infra.py::TestSyncInfraLMI_1::test_sync_infra_lmi_with_capacity_provider_config - subprocess.TimeoutExpired:  timed out after 600 seconds
FAILED tests/integration/sync/test_sync_infra.py::TestSyncInfraLMI_0::test_sync_infra_lmi_with_capacity_provider_config - subprocess.TimeoutExpired:  timed out after 600 seconds
FAILED tests/integration/sync/test_sync_watch.py::TestSyncWatchCodeLMI_0::test_sync_watch_code_lmi - TimeoutError: Did not get expected output after 600 seconds.
FAILED tests/integration/sync/test_sync_watch.py::TestSyncWatchCodeLMI_1::test_sync_watch_code_lmi - TimeoutError: Did not get expected output after 600 seconds.
  • other-and-e2e (docker)
ERROR    tests.testing_utils:testing_utils.py:159 Command: ['samdev', 'deploy', '--capabilities', 'CAPABILITY_IAM', 'CAPABILITY_AUTO_EXPAND', '--parameter-overrides', 'SubnetId=subnet-09e8a20085f708958 SecurityGroupId=sg-0eab87ac0deca57f8', '--stack-name', 'TestingInvokeWithCapacityProvider-deca398e53404429897d3581904d85b1', '--template-file', '/home/runner/work/aws-sam-cli/aws-sam-cli/tests/integration/testdata/remote_invoke/template-single-lambda-capacity-provider.yaml', '--resolve-s3'], TIMED OUT
ERROR    tests.testing_utils:testing_utils.py:160 Return Code: None
  • package-delete-deploy (finch)
FAILED tests/integration/deploy/test_deploy_command.py::TestDeploy::test_deploy_lmi_function - subprocess.TimeoutExpired:  timed out after 600 seconds
  • sync (finch)
FAILED tests/integration/sync/test_sync_infra.py::TestSyncInfraLMI_1::test_sync_infra_lmi_with_capacity_provider_config - subprocess.TimeoutExpire: timed out after 600 seconds
FAILED tests/integration/sync/test_sync_watch.py::TestSyncWatchCodeLMI_0::test_sync_watch_code_lmi - TimeoutError: Did not get expected output after 600 seconds. 
FAILED tests/integration/sync/test_sync_infra.py::TestSyncInfraLMI_0::test_sync_infra_lmi_with_capacity_provider_config - subprocess.TimeoutExpired: timed out after 600 seconds
FAILED tests/integration/sync/test_sync_watch.py::TestSyncWatchCodeLMI_1::test_sync_watch_code_lmi - TimeoutError: Did not get expected output after 600 seconds.'
  • other-and-e2e (finch)
ERROR    tests.testing_utils:testing_utils.py:159 Command: ['samdev', 'deploy', '--capabilities', 'CAPABILITY_IAM', 'CAPABILITY_AUTO_EXPAND', '--parameter-overrides', 'SubnetId=subnet-0edb332c62c9bdd99 SecurityGroupId=sg-0034438318dab75be', '--stack-name', 'TestingInvokeWithCapacityProvider-ddbb2002fd604e89acdaf18dfadca067', '--template-file', '/home/runner/work/aws-sam-cli/aws-sam-cli/tests/integration/testdata/remote_invoke/template-single-lambda-capacity-provider.yaml', '--resolve-s3'], TIMED OUT
ERROR    tests.testing_utils:testing_utils.py:160 Return Code: None

@vicheey vicheey added this pull request to the merge queue Jan 16, 2026
@vicheey
Copy link
Contributor Author

vicheey commented Jan 16, 2026

Test failure happened because of insufficient kms permission for the test acccount.

Merged via the queue into develop with commit 17114df Jan 16, 2026
59 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants