-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(test): update skip condition for LMI test #8562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerena
previously approved these changes
Jan 13, 2026
ad43111 to
64b9975
Compare
valerena
reviewed
Jan 13, 2026
Contributor
Author
|
TODO:
|
Contributor
Author
|
Running new tests: Integration Tests · aws/aws-sam-cli@ff61763 |
seshubaws
approved these changes
Jan 15, 2026
valerena
approved these changes
Jan 16, 2026
Contributor
Author
|
Not do merge yet. Investigating test failures. Test failure:
|
Contributor
Author
|
Test failure happened because of insufficient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Some of the test account do not have the necessary resources deployed to run LMI test succesfully.
We need to skip the tests for now if required resources are available yet.
Why is this change necessary?
We had this #8554 which skip all LMI test and need manual change to re-enable the test.
How does it address the issue?
Make the skip condition depend on each test account available stack.
What side effects does this change have?
No. All the test already skip.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.