feat(build): graduate Rust cargo-lambda support from experimental#8526
Open
bnusunny wants to merge 4 commits intoaws:developfrom
Open
feat(build): graduate Rust cargo-lambda support from experimental#8526bnusunny wants to merge 4 commits intoaws:developfrom
bnusunny wants to merge 4 commits intoaws:developfrom
Conversation
bnusunny
force-pushed
the
move_rust_outof_experimental
branch
from
f229671 to
5d67b74
Compare
Remove the experimental/beta flag requirement for building Rust functions with the rust-cargolambda build method. Users no longer need to pass --beta-features or set SAM_CLI_BETA_RUST_CARGO_LAMBDA=1 to build Rust Lambda functions. Changes: - Remove RustCargoLambda from ExperimentalFlag class - Remove _check_rust_cargo_experimental_flag() method from BuildContext - Update integration tests to not require beta_features flag - Update unit tests to remove mock for deleted method
bnusunny
force-pushed
the
move_rust_outof_experimental
branch
from
5d67b74 to
23f5ed0
Compare
Member
|
|
- Add CargoLambda to ExperimentalFlag with persistent=True - Update is_experimental_enabled() to always return True for persistent flags - Update unit tests for new flag count and persistent behavior
Contributor
Author
|
Fixed now. |
valerena
reviewed
Jan 12, 2026
Comment on lines
+57
to
+60
| # CargoLambda is no longer experimental - always enabled | ||
| CargoLambda = ExperimentalEntry( | ||
| "experimentalCargoLambda", EXPERIMENTAL_ENV_VAR_PREFIX + "CARGO_LAMBDA", persistent=True | ||
| ) |
Contributor
There was a problem hiding this comment.
Isn't this something we should remove in Lambda Builders instead (or Lambda Builders first)? Here: https://github.com/aws/aws-lambda-builders/blob/1d2de0531053ef5b24e1332c976b198090dbeafe/aws_lambda_builders/workflows/rust_cargo/workflow.py#L39-L43
We don't need to keep this CargoLambda flag here if lambda-builders doesn't check for the flag over there, and we don't need to add the "persistent" field.
Contributor
There was a problem hiding this comment.
I agree that it would be better to remove the flag rather than mark the beta flag as perpetually true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
Lambda Rust Runtime is General Available. We need to graduate Rust cargo-lambda support from experimental.
How does it address the issue?
Remove the experimental/beta flag requirement for building Rust functions with the rust-cargolambda build method. Users no longer need to pass --beta-features or set SAM_CLI_BETA_RUST_CARGO_LAMBDA=1 to build Rust Lambda functions.
Changes:
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.