Refer SLURM_SCONTROL_RESUME_FAILED_STATE in is_bootstrap_failure comment#703
Merged
hehe7318 merged 1 commit intoApr 30, 2026
Conversation
Avoid hard-coding the state flags in the inline comment so future changes to the constant do not require a comment update.
gmarciani
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup to #702. The inline comment above the
is_bootstrap_timeout()branch inDynamicNode.is_bootstrap_failure()was hard-coding the expected flags (DOWN+CLOUD+POWERED_DOWN+NOT_RESPONDING). After #702 changed the constant toDOWN+CLOUD+POWERED_DOWN, the comment drifted from the code.Replace the hard-coded flags with a reference to the
SLURM_SCONTROL_RESUME_FAILED_STATEconstant so future changes to the state set don't require touching this comment.Test plan