Skip to content

Raise TypeError on bare @requires_crt, fix existing bare @requires_crt usages, and add regression tests#10129

Open
Alan4506 wants to merge 1 commit intoaws:developfrom
Alan4506:requires_crt_fix
Open

Raise TypeError on bare @requires_crt, fix existing bare @requires_crt usages, and add regression tests#10129
Alan4506 wants to merge 1 commit intoaws:developfrom
Alan4506:requires_crt_fix

Conversation

@Alan4506
Copy link

Background:
requires_crt is used to skip tests when the optional CRT dependency is not installed. The only supported form should be @requires_crt(). However, the current codebase mixes both @requires_crt and @requires_crt() forms. Using bare @requires_crt is unsafe because requires_crt is implemented as a decorator factory. Python passes the test function as the reason argument, causing the real test body to never run. Assertions are never evaluated, but the test may still appear to pass or skip silently.

Description of changes:
This PR makes bare @requires_crt fail immediately with a TypeError. Four existing bare @requires_crt usages across test files are updated to @requires_crt().

Testing:
Regression tests are added to verify correct behavior. All tests including the new tests pass.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.41%. Comparing base (c4681b5) to head (8268193).
⚠️ Report is 185 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10129      +/-   ##
===========================================
+ Coverage    93.39%   93.41%   +0.02%     
===========================================
  Files          210      210              
  Lines        17052    17150      +98     
===========================================
+ Hits         15925    16020      +95     
- Misses        1127     1130       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants