Raise TypeError on bare @requires_crt, fix existing bare @requires_crt usages, and add regression tests#10129
Open
Alan4506 wants to merge 1 commit intoaws:developfrom
Open
Raise TypeError on bare @requires_crt, fix existing bare @requires_crt usages, and add regression tests#10129Alan4506 wants to merge 1 commit intoaws:developfrom
Alan4506 wants to merge 1 commit intoaws:developfrom
Conversation
…res_crt usages, and add regression tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10129 +/- ##
===========================================
+ Coverage 93.39% 93.41% +0.02%
===========================================
Files 210 210
Lines 17052 17150 +98
===========================================
+ Hits 15925 16020 +95
- Misses 1127 1130 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdaily
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
requires_crtis used to skip tests when the optional CRT dependency is not installed. The only supported form should be@requires_crt(). However, the current codebase mixes both@requires_crtand@requires_crt()forms. Using bare@requires_crtis unsafe becauserequires_crtis implemented as a decorator factory. Python passes the test function as thereasonargument, causing the real test body to never run. Assertions are never evaluated, but the test may still appear to pass or skip silently.Description of changes:
This PR makes bare
@requires_crtfail immediately with aTypeError. Four existing bare@requires_crtusages across test files are updated to@requires_crt().Testing:
Regression tests are added to verify correct behavior. All tests including the new tests pass.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.