Fix/history file permissions #10013
Open
Fix/history file permissions #10013
+282
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashovlin
requested changes
Jan 23, 2026
tests/functional/test_telemetry.py
Outdated
|
|
||
| def test_create_database_file_with_secure_permissions(self): | ||
| cache_dir = self.files.full_path('cache') | ||
| os.makedirs(cache_dir, mode=0o700) |
Member
There was a problem hiding this comment.
Why are we making the directory in the test code? Isn't the code under test responsible for that?
Contributor
Author
There was a problem hiding this comment.
Updated to let the code create the directory in next revision
…, add cached credentials protection
ashovlin
reviewed
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Use specific permissions. Changes apply to: CLI history database, telemetry session database, Autoprompt history file.
Description of tests: Permission tests use the @skip_if_windows decorator since Unix permission bits don't apply to Windows. Windows relies on ACL inheritance from parent directories instead. The CI pipeline skips these tests on Windows builds as intended.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.