Skip to content

Skip empty configuration values when writing AWS CLI config #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gopesh111 wants to merge 3 commits into
base: develop
Choose a base branch
from
+14 −0
Open

Skip empty configuration values when writing AWS CLI config #10003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57d6374
Skip empty configuration values when writing AWS CLI config
Gopesh111 Jan 20, 2026
3fe3e58
Add test to ensure empty config values are not written
Gopesh111 Jan 20, 2026
f76d799
Fix test to follow unittest style for empty config values
Gopesh111 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions awscli/customizations/configure/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ def _insert_new_values(self, line_number, contents, new_values, indent=''):
new_contents.append('%s%s = %s\n' % (subindent, subkey,
subval))
else:
if value is None:
continue
if isinstance(value, str) and not value.strip():
continue
new_contents.append('%s%s = %s\n' % (indent, key, value))
del new_values[key]
contents.insert(line_number + 1, ''.join(new_contents))
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/customizations/configure/test_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,3 +369,13 @@ def test_appends_newline_on_new_section(self):
'[new-section]\n'
'region = us-west-2\n'
)
def test_writer_skips_empty_values(self):
self.writer.update_config(
{'region': '', '__section__': 'default'},
self.config_filename
)
with open(self.config_filename, 'r') as f:
contents = f.read()
self.assertNotIn('region', contents)