generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 74
fix(cli): remove legacy stack tags behavior #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws-cdk-cli into huijbers/no-more-legacy-stack-tags
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
- Coverage 87.70% 87.69% -0.01%
==========================================
Files 72 72
Lines 10095 10095
Branches 1332 1332
==========================================
- Hits 8854 8853 -1
- Misses 1216 1217 +1
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's some nasty legacy around Stack Tags:
{ Key, Value }object that got directly passed into the CloudFormation CreateChangeSet API.{ key, value }in memory (otherwise jsii would yell at us). For backwards compatibility with the on-disk format and the (extracted) JSONSchema Validation, we used to re-case the identifiers: just before they were written to disk we would changekey → Keyand just after reading from disk but before validation and we would changeKey → key.tagsproperty to the CloudFormation Stack artifact in the CDK manifest, and the CLI and other tools stopped using the stack metadata to read stack tags.Since this is to support end-of-life CDKs, in this PR I'm taking some of that complexity out; we stop converting
key → Keywhen writing a cloud assembly manifest -- but we do still have to convertKey → keyin order to pass JSONSchema validation as we read the manifest. Tags are exclusively read from the artifact properties, there will be no fallback to the metadata anymore.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license