Skip to content

fix: move conn.release_resources() to close method #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
faviansamatha wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −3
Draft

fix: move conn.release_resources() to close method #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions aws_advanced_python_wrapper/wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,15 +222,13 @@ def release_resources(self):
def _unwrap(self, unwrap_class: Type[UnwrapType]) -> Optional[UnwrapType]:
return self._plugin_manager._unwrap(unwrap_class)

def __del__(self):
self.release_resources()

def __enter__(self: AwsWrapperConnection) -> AwsWrapperConnection:
return self

def __exit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> None:
self._plugin_manager.execute(self.target_connection, DbApiMethod.CONNECTION_CLOSE,
lambda: self.target_connection.close(), exc_type, exc_val, exc_tb)
self.release_resources()


class AwsWrapperCursor(Cursor):
Expand Down
Loading