Open
Conversation
karenc-bq
force-pushed
the
feat/gdb-failover
branch
3 times, most recently
from
cc4c6aa to
bcc243b
Compare
karenc-bq
force-pushed
the
refactor/monitor-service
branch
from
81930fe to
00d8176
Compare
karenc-bq
force-pushed
the
feat/gdb-failover
branch
2 times, most recently
from
5b7069a to
14c1bb3
Compare
sophia-bq
reviewed
Mar 16, 2026
common/lib/host_list_provider/connection_string_host_list_provider.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // Check writer region to determine failover mode | ||
| const writerRegion = this.rdsHelper.getRdsRegion(writerCandidate.host); |
Contributor
There was a problem hiding this comment.
Can this return null? Would we have issues if it does?
Contributor
Author
There was a problem hiding this comment.
equalsIgnoreCase has null checks and would return false if writerRegion is null
karenc-bq
force-pushed
the
feat/gdb-failover
branch
from
14c1bb3 to
f253acb
Compare
karenc-bq
force-pushed
the
feat/gdb-failover
branch
from
f253acb to
6167281
Compare
sophia-bq
approved these changes
Mar 26, 2026
Comment on lines
+244
to
+245
| if (!(ex instanceof FailoverFailedError)) { | ||
| this.failoverWriterFailedCounter.inc(); |
Contributor
There was a problem hiding this comment.
This is a bit confusing could we maybe add a comment explaining that we only want to increment the counter if we haven't already marked it and then thrown a failover failed error? Also what is the benefit to marking it above instead of just always incrementing it here? Is it about timing?
Contributor
Author
There was a problem hiding this comment.
Added comment. It is already incremented in Failover2Plugin.
common/lib/host_list_provider/monitoring/cluster_topology_monitor.ts
Outdated
Show resolved
Hide resolved
common/lib/host_list_provider/monitoring/cluster_topology_monitor.ts
Outdated
Show resolved
Hide resolved
karenc-bq
force-pushed
the
feat/gdb-failover
branch
from
ae2a9f6 to
0162bac
Compare
sophia-bq
reviewed
Apr 6, 2026
common/lib/host_list_provider/monitoring/cluster_topology_monitor.ts
Outdated
Show resolved
Hide resolved
faviansamatha
approved these changes
Apr 6, 2026
sophia-bq
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.