Skip to content

Fix AuthProfile deserialization for social login profiles #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syedair wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

Fix AuthProfile deserialization for social login profiles #3704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions crates/chat-cli/src/database/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ pub struct CredentialsJson {
#[derive(Clone, Debug, Deserialize, Serialize)]
pub struct AuthProfile {
pub arn: String,
#[serde(alias = "profileName")]
pub profile_name: String,
}

Expand Down Expand Up @@ -669,6 +670,20 @@ mod tests {
store.delete_secret(key).await.unwrap();
}

#[test]
fn test_auth_profile_deserialization_snake_case() {
let json = r#"{"arn":"arn:aws:codewhisperer:us-east-1:123456:profile/TEST","profile_name":"TestProfile"}"#;
let profile: AuthProfile = serde_json::from_str(json).unwrap();
assert_eq!(profile.profile_name, "TestProfile");
}

#[test]
fn test_auth_profile_deserialization_camel_case() {
let json = r#"{"arn":"arn:aws:codewhisperer:us-east-1:123456:profile/TEST","profileName":"TestProfile"}"#;
let profile: AuthProfile = serde_json::from_str(json).unwrap();
assert_eq!(profile.profile_name, "TestProfile");
}

#[tokio::test]
#[ignore = "not on ci"]
async fn secret_delete() {
Expand Down