E2e rosa #482
Draft
E2e rosa #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okankoAMZ
commented
Mar 18, 2025
okankoAMZ
commented
Mar 18, 2025
okankoAMZ
commented
Mar 18, 2025
okankoAMZ
commented
Mar 18, 2025
okankoAMZ
commented
Mar 18, 2025
musa-asad
reviewed
Mar 18, 2025
| @@ -0,0 +1,5 @@ | |||
| [ | |||
| { | |||
| "nodes": 2 | |||
Contributor
There was a problem hiding this comment.
you can remove this if you don't end up using it -- it's meant to determine the number of nodes on the cluster
musa-asad
reviewed
Mar 18, 2025
musa-asad
reviewed
Mar 18, 2025
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # |
Contributor
There was a problem hiding this comment.
nit: verify if we need to include this license
musa-asad
reviewed
Mar 18, 2025
musa-asad
reviewed
Mar 18, 2025
| @@ -1,140 +1,102 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: MIT | |||
|
|
|||
musa-asad
reviewed
Mar 18, 2025
musa-asad
reviewed
Mar 18, 2025
| "context" | ||
| "flag" | ||
| "fmt" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
Contributor
There was a problem hiding this comment.
might need to re-organize imports
musa-asad
reviewed
Mar 18, 2025
| } | ||
| } | ||
|
|
||
| func testMetrics(t *testing.T) { |
Contributor
There was a problem hiding this comment.
would rename since it doesn't test metrics
musa-asad
reviewed
Mar 18, 2025
| //}, | ||
| //"ClusterName-reason": { | ||
| // "apiserver_flowcontrol_rejected_requests_total", | ||
| //}, |
Contributor
There was a problem hiding this comment.
nit: remove comments if not descriptive
musa-asad
previously approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Describe the problem or feature in addition to a link to the issues.
Description of changes
How does this change address the problem?
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.