fix(metrics): align addDimensions() boundary check with addDimension()#5236
Open
blut-agent wants to merge 1 commit into
Open
fix(metrics): align addDimensions() boundary check with addDimension()#5236blut-agent wants to merge 1 commit into
blut-agent wants to merge 1 commit into
Conversation
Closes aws-powertools#5204 The addDimensions() method used >= for the dimension count check while addDimension() used <=, causing addDimensions() to reject the 29th dimension while addDimension() would allow it. Changed >= to > to match the behavior of addDimension().
|
Contributor
|
Apologies, the linked issue for this bug was incorrect, this current fix would cap the number of dimensions at 28 when the behaviour we want is to allow 29. I have updated the issue. Please note that all PRs must always have tests where possible. We need to test that this behaviour is now consistent across both methods. Finally, please note that any repeat of the behaviour you displayed in #5212 will result in this PR being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
The
addDimensions()method used>=for the dimension count comparison whileaddDimension()used<=. This causedaddDimensions()to reject the 29th dimension whileaddDimension()would allow it, sinceMAX_DIMENSION_COUNTis 29.Changed
>=to>inaddDimensions()to match the behavior ofaddDimension().Issue number: closes #5204
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.