feat(runtime): Add --enable-cross-namespace flag#248
Merged
ack-prow[bot] merged 2 commits intoMay 27, 2026
Merged
Conversation
Introduce a single CLI flag that controls all three categories of cross-namespace behavior: resource references, secret references, and field exports. Phase 1 defaults to true with deprecation warnings. Changes: - Rename --enable-cross-namespace-references to --enable-cross-namespace - Change default from false to true (Phase 1 warning behavior) - Update ValidateCrossNamespaceReference to return (string, bool, error) - Add ValidateCrossNamespaceReferenceString convenience wrapper - Add ACK.CrossNamespaceDeprecation condition type - Integrate cross-namespace check into SecretValueFromReference - Integrate cross-namespace check into field export reconciler - Add table-driven unit tests for both helper functions - Update error messages to reference new flag name
- Use nil-safe targetName variable in field export log line (comment aws-controllers-k8s#2) - Use lookup-or-create pattern in setCrossNsOptInRequiredCondition to avoid duplicate conditions (comment aws-controllers-k8s#3) - Return ownerNamespace instead of empty string on error in ValidateCrossNamespaceReference for defensive fail-closed behavior (comment aws-controllers-k8s#4) - Update tests to match new return value on error path
kprahulraj
force-pushed
the
feat/enable-cross-namespace
branch
from
b8985c1 to
9e63b3e
Compare
knottnt
approved these changes
May 22, 2026
Contributor
knottnt
left a comment
knottnt
left a comment
There was a problem hiding this comment.
Runtime changes look good.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, kprahulraj, sapphirew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Introduce a single CLI flag that controls all three categories of cross-namespace behavior: resource references, secret references, and field exports. It defaults to true with deprecation warnings to start with. It will default to false later in order to follow best security practice.
Changes:
--enable-cross-namespaceCLI flag with default valuetrueACK.CrossNamespaceOptInRequiredcondition typeNote: This PR builds on @sapphirew work in #239 and addresses review feedback from @cheeseandcereal :
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.