Skip to content

test: add E2E tests for --enable-cross-namespace flag#175

Open
sapphirew wants to merge 1 commit into
aws-controllers-k8s:mainfrom
sapphirew:test/cross-namespace
Open

test: add E2E tests for --enable-cross-namespace flag#175
sapphirew wants to merge 1 commit into
aws-controllers-k8s:mainfrom
sapphirew:test/cross-namespace

Conversation

@sapphirew
Copy link
Copy Markdown

Issue #, if available:

Description of changes:

Regenerate iam-controller using updated code-generator and runtime that introduce the unified --enable-cross-namespace flag with phased rollout.

Generated code changes:

  • Renames EnableCrossNamespaceReferences to EnableCrossNamespace
  • Updates ValidateCrossNamespaceReference to return (string, bool, error)
  • Adds --enable-cross-namespace flag to Helm deployment template
  • Adds enableCrossNamespace: true to Helm values (Phase 1 default)

E2E tests cover three scenarios:

  • flag=true (Phase 1 default): cross-namespace ref succeeds with ACK.CrossNamespaceDeprecation condition as deprecation warning
  • flag=false: cross-namespace ref rejected with ACK.Terminal condition containing the --enable-cross-namespace flag name
  • same-namespace: ref always succeeds regardless of flag value with no deprecation condition present

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow Bot requested review from gustavodiaz7722, jlbutler and knottnt May 7, 2026 01:05
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sapphirew
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kprahulraj
Copy link
Copy Markdown

Doc changes is added - aws-controllers-k8s/docs#37

@sapphirew sapphirew force-pushed the test/cross-namespace branch 4 times, most recently from 209b346 to d616ec2 Compare May 28, 2026 17:35
@sapphirew sapphirew changed the title [Draft] feat: add E2E tests for --enable-cross-namespace flag test: add E2E tests for --enable-cross-namespace flag May 28, 2026
Bump runtime to v0.59.2-0.20260527214203-0e3ba692e1c5 which includes
the --enable-cross-namespace-references flag and shared helper.
Regenerate all resource code from the updated code-generator to call
ackrt.ValidateCrossNamespaceReference in resolveReferenceFor<Field>.

Includes Helm chart updates to expose the flag and E2E test for
cross-namespace reference behavior.
@sapphirew sapphirew force-pushed the test/cross-namespace branch from d616ec2 to 01b525c Compare May 28, 2026 21:29
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 28, 2026

@sapphirew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
iam-crd-compat-check 5284d5a link true /test iam-crd-compat-check
iam-verify-code-gen 01b525c link true /test iam-verify-code-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants