feat: add SupportedRegions field to VPCEndpointServiceConfiguration#337
Open
michaelhtm wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
force-pushed
the
feat/add-supported-regions-to-vpc-endpoint-service
branch
from
369cb3b to
9946080
Compare
The field was previously ignored. Users can now specify which regions service consumers can access the endpoint service from. Uses set.from to extract Region from SupportedRegionDetail on read, and Add/Remove semantics on update via ModifyVpcEndpointServiceConfiguration. Resolves aws-controllers-k8s/community#2902
michaelhtm
force-pushed
the
feat/add-supported-regions-to-vpc-endpoint-service
branch
from
9946080 to
b29ad48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The field was previously ignored. Users can now specify which regions
service consumers can access the endpoint service from. Uses set.from
to extract Region from SupportedRegionDetail on read, and Add/Remove
semantics on update via ModifyVpcEndpointServiceConfiguration.
Resolves aws-controllers-k8s/community#2902
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.