Skip to content

fix: prevent false drift in VPCEndpoint and SecurityGroup resources#336

Open
michaelhtm wants to merge 1 commit into
aws-controllers-k8s:mainfrom
michaelhtm:fix/vpc-endpoint-policy-and-sg-rules-drift
Open

fix: prevent false drift in VPCEndpoint and SecurityGroup resources#336
michaelhtm wants to merge 1 commit into
aws-controllers-k8s:mainfrom
michaelhtm:fix/vpc-endpoint-policy-and-sg-rules-drift

Conversation

@michaelhtm
Copy link
Copy Markdown
Member

Description of changes:
VPCEndpoint: Add is_iam_policy for PolicyDocument (semantic JSON compare
instead of string compare), add late_initialize for ServiceRegion.

SecurityGroup: Replace order-sensitive DeepEqual for IngressRules/
EgressRules with set-based containsRule comparison via delta_pre_compare
hook, preventing false diffs from rule ordering differences.

Resolves aws-controllers-k8s/community#2695
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow Bot requested review from gustavodiaz7722 and sapphirew May 26, 2026 22:06
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow Bot added the approved label May 26, 2026
VPCEndpoint: Add is_iam_policy for PolicyDocument (semantic JSON compare
instead of string compare), add late_initialize for ServiceRegion.

SecurityGroup: Replace order-sensitive DeepEqual for IngressRules/
EgressRules with set-based containsRule comparison via delta_pre_compare
hook, preventing false diffs from rule ordering differences.

Resolves aws-controllers-k8s/community#2695
@michaelhtm michaelhtm force-pushed the fix/vpc-endpoint-policy-and-sg-rules-drift branch from 2ee6c22 to 4b26006 Compare May 26, 2026 22:16
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 26, 2026

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-kind-e2e 4b26006 link true /test ec2-kind-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RDS controller]: constant loop of changing the db in the cloud

1 participant