fix: prevent false drift in VPCEndpoint and SecurityGroup resources#336
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VPCEndpoint: Add is_iam_policy for PolicyDocument (semantic JSON compare instead of string compare), add late_initialize for ServiceRegion. SecurityGroup: Replace order-sensitive DeepEqual for IngressRules/ EgressRules with set-based containsRule comparison via delta_pre_compare hook, preventing false diffs from rule ordering differences. Resolves aws-controllers-k8s/community#2695
2ee6c22 to
4b26006
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of changes:
VPCEndpoint: Add is_iam_policy for PolicyDocument (semantic JSON compare
instead of string compare), add late_initialize for ServiceRegion.
SecurityGroup: Replace order-sensitive DeepEqual for IngressRules/
EgressRules with set-based containsRule comparison via delta_pre_compare
hook, preventing false diffs from rule ordering differences.
Resolves aws-controllers-k8s/community#2695
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.