-
Notifications
You must be signed in to change notification settings - Fork 11
docs: add breaking changes page for cross-namespace default change #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| title: "Breaking Changes" | ||
| sidebar_position: 99 | ||
| --- | ||
|
|
||
| # Breaking Changes | ||
|
|
||
| This page tracks upcoming breaking changes to ACK controller defaults and behavior. Review this page before upgrading your controllers. | ||
|
|
||
| ## Cross-Namespace References Default Change | ||
|
|
||
| :::warning[Breaking Change Notice] | ||
| The default value of `--enable-cross-namespace` will change from `true` to `false` in a future release. The warning condition serves as a deprecation notice of existing default functionality. | ||
| ::: | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We might explicitly say "The warning serves as a deprecation notice of existing default functionality". Up to you if you'd like to include that.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated |
||
| ### Summary | ||
|
|
||
| Cross-namespace resource references (including `*Ref` fields, `SecretKeyReference`, and `FieldExport` targets across namespaces) will require explicit opt-in to improve namespace isolation. | ||
|
|
||
| ### Timeline | ||
|
|
||
| | Phase | Description | | ||
| |:------|:------------| | ||
| | **Phase 1 (current)** | Flag added with default `true`. Warning condition set on resources using cross-namespace references | | ||
| | **Phase 2**<br/>**(future release)** | Flag default changes to `false`. Cross-namespace references rejected unless opted in | | ||
|
|
||
| ### Who is affected | ||
|
|
||
| You are affected if any of your ACK resources: | ||
| - Use `*Ref` fields pointing to resources in a **different namespace** | ||
| - Use `SecretKeyReference` with a `namespace` field different from the resource's namespace | ||
| - Use `FieldExport` CRs targeting ConfigMaps/Secrets in a different namespace than the source | ||
|
|
||
| If all your references are within the same namespace, **no action is needed**. | ||
|
|
||
| ### Action required | ||
|
|
||
| If you use cross-namespace references, explicitly opt in before upgrading to the Phase 2 release: | ||
|
|
||
| ```yaml | ||
| # values.yaml | ||
| enableCrossNamespace: true | ||
| ``` | ||
|
|
||
| Or via controller flag: | ||
| ``` | ||
| --enable-cross-namespace=true | ||
| ``` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,18 @@ The [ack-dev-skills](https://github.com/aws-controllers-k8s/ack-dev-skills) proj | |
|
|
||
| If you use AI coding tools (Claude Code, Kiro, Cursor, etc.), installing this skill will significantly improve the quality of AI-assisted ACK development work. See the [ack-dev-skills README](https://github.com/aws-controllers-k8s/ack-dev-skills) for installation instructions. | ||
|
|
||
| ## Documenting Breaking Changes | ||
|
|
||
| If your PR introduces a breaking change (e.g., changing a default value, removing a flag, altering reconciliation behavior), you must update the [Breaking Changes](/docs/breaking-changes) page. | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we open an issue to make a corresponding guidance change in the ack-dev skill?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| Add an entry with: | ||
| - A clear description of what is changing | ||
| - Timeline (if phased rollout) | ||
| - Who is affected | ||
| - Action required for users to migrate | ||
|
|
||
| This ensures users are informed before upgrading their controllers. | ||
|
|
||
| ## Community | ||
|
|
||
| - [GitHub Issues](https://github.com/aws-controllers-k8s/community/issues) — Bug reports and feature requests | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upcoming only, or does this page also track previously communicated and shipped breaking changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - this should track both upcoming and previously shipped breaking changes. Do you have a list of previous breaking changes that I can add here? I'll update the wording once we have those documented