Skip to content

Add resource-level note to DocumentationConfig#710

Open
knottnt wants to merge 1 commit into
aws-controllers-k8s:mainfrom
knottnt:resource-level-docs
Open

Add resource-level note to DocumentationConfig#710
knottnt wants to merge 1 commit into
aws-controllers-k8s:mainfrom
knottnt:resource-level-docs

Conversation

@knottnt
Copy link
Copy Markdown
Contributor

@knottnt knottnt commented May 29, 2026

Issue #, if available:

Description of changes:
Adds a note field to ResourceDocsConfig that allows service controllers to document special considerations for a resource via documentation.yaml. The note is later consumed by the ACK docs website and displayed in the resource's API Reference page.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds a `note` field to ResourceDocsConfig that allows service controllers
to document special considerations for a resource via documentation.yaml.
The note is exposed through a CRD.Note() method for downstream consumers.
@ack-prow ack-prow Bot requested review from a-hilaly and jlbutler May 29, 2026 22:20
@ack-prow ack-prow Bot added the approved label May 29, 2026
Copy link
Copy Markdown
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm

@ack-prow ack-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm
Copy link
Copy Markdown
Member

/hold

@ack-prow ack-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2026
@michaelhtm
Copy link
Copy Markdown
Member

/retest

@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 29, 2026

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ecr-controller-test fcb7c59 link true /test ecr-controller-test
eks-controller-test fcb7c59 link true /test eks-controller-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants