Add updateable and deletable status guards for resources#685
Open
sapphirew wants to merge 2 commits intoaws-controllers-k8s:mainfrom
Open
Add updateable and deletable status guards for resources#685sapphirew wants to merge 2 commits intoaws-controllers-k8s:mainfrom
sapphirew wants to merge 2 commits intoaws-controllers-k8s:mainfrom
Conversation
…IsDeletable template functions Add GoCodeResourceIsUpdateable and GoCodeResourceIsDeletable entries to controllerFuncMap in controller.go, following the same signature pattern as GoCodeIsSynced. These template functions invoke the corresponding code generation functions from updateable.go.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sapphirew The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/retest |
3 similar comments
Author
|
/retest |
Author
|
/retest |
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add generator.yaml configuration and template functions that allow service controllers to declare which status field values permit update and delete operations. When a resource is not in an allowed state, the generated code requeues the operation with a configurable delay instead of attempting the API call.
New config blocks
updateableanddeletableon ResourceConfig accept a list of status field path + allowed-values conditions and an optional requeue_after_seconds override (default 30s). Template functions GoCodeResourceIsUpdateable and GoCodeResourceIsDeletable are injected into sdk_update, sdk_update_custom, sdk_update_set_attributes, and sdk_delete templates respectively.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.