fix: export on certificate adoption#95
fix: export on certificate adoption#95alexwang0311 wants to merge 3 commits intoaws-controllers-k8s:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexwang0311 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @alexwang0311. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
aws-controllers-k8s/community#2825.
Description of changes:
See related ack runtime and code generator changes:
runtime: feat: add hook into resource adoption runtime#232code-generator: feat: add hook into resource adoption code-generator#680Currently
acm-controllerrelies on a state transition out of anull stateto export on resource creation (IssuedAtchanges fromnulltonon-null). However, when a certificate is adopted, the reconciler skips this null state transition. In general, if a controller has custom logic that depends on a transition into or out of anull state, it won't work when the resource is adopted since the resource won't have anull state(i.e. whenservices.k8s.aws/deletion-policy: retain, the delete code path is skipped by the ack runtime, which skips a potential transition into anull statefor a custom resource).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.