Skip to content

fix: export on certificate adoption#95

Draft
alexwang0311 wants to merge 3 commits intoaws-controllers-k8s:mainfrom
alexwang0311:adopted-certificate-export-fix
Draft

fix: export on certificate adoption#95
alexwang0311 wants to merge 3 commits intoaws-controllers-k8s:mainfrom
alexwang0311:adopted-certificate-export-fix

Conversation

@alexwang0311
Copy link
Copy Markdown
Contributor

Issue #, if available:
aws-controllers-k8s/community#2825.

Description of changes:
See related ack runtime and code generator changes:

  1. runtime: feat: add hook into resource adoption runtime#232
  2. code-generator: feat: add hook into resource adoption code-generator#680

Currently acm-controller relies on a state transition out of a null state to export on resource creation (IssuedAt changes from null to non-null). However, when a certificate is adopted, the reconciler skips this null state transition. In general, if a controller has custom logic that depends on a transition into or out of a null state, it won't work when the resource is adopted since the resource won't have a null state (i.e. when services.k8s.aws/deletion-policy: retain, the delete code path is skipped by the ack runtime, which skips a potential transition into a null state for a custom resource).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026
@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm March 23, 2026 02:17
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexwang0311
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Mar 23, 2026

Hi @alexwang0311. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant