-
Notifications
You must be signed in to change notification settings - Fork 821
feat(gen2-migration): amplify-migration-system executes e2e flow for amplify init, using atmosphere credentials or local profile #14432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iankhou
wants to merge
6
commits into
gen2-migration
Choose a base branch
from
iankhou-gen2-migration-e2e
base: gen2-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13,491
−9,004
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
147cb3c
feat: amplify-migration-e2e-system
iankhou c78a8d2
yarn.lock update
iankhou ca279a5
test setup ts errors
iankhou 1a5d3af
removal of some debug logs
iankhou a1cc93f
yarn.lock update
iankhou 07898ab
added dependency to e2e core package in amplify-migration-system
iankhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "app": { | ||
| "name": "app-4", | ||
| "description": "Fitness goal tracker with progress photos and authentication logging", | ||
| "framework": "react" | ||
| }, | ||
| "categories": { | ||
| "api": { | ||
| "type": "GraphQL", | ||
| "schema": "schema.graphql", | ||
| "authModes": ["API_KEY", "COGNITO_USER_POOLS"] | ||
| }, | ||
| "auth": { | ||
| "signInMethods": ["email"], | ||
| "socialProviders": [] | ||
| }, | ||
| "storage": { | ||
| "buckets": [ | ||
| { | ||
| "name": "progress-photos", | ||
| "access": ["auth", "guest"] | ||
| } | ||
| ] | ||
| }, | ||
| "function": { | ||
| "functions": [ | ||
| { | ||
| "name": "quotegenerator", | ||
| "runtime": "nodejs", | ||
| "template": "hello-world" | ||
| } | ||
| ] | ||
| }, | ||
| "hosting": { | ||
| "type": "amplify-console" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| { | ||
| "app": { | ||
| "name": "app-5", | ||
| "description": "Advanced fitness goal tracker with stress-test schema, comprehensive logging, and authentication triggers", | ||
| "framework": "react" | ||
| }, | ||
| "categories": { | ||
| "api": { | ||
| "type": "GraphQL", | ||
| "schema": "schema.graphql", | ||
| "authModes": ["API_KEY", "COGNITO_USER_POOLS"], | ||
| "customQueries": ["getRandomQuote"] | ||
| }, | ||
| "auth": { | ||
| "signInMethods": ["email"], | ||
| "socialProviders": [], | ||
| "userPoolConfig": { | ||
| "emailVerification": true, | ||
| "mfaConfiguration": { | ||
| "mode": "OFF" | ||
| } | ||
| }, | ||
| "triggers": { | ||
| "postAuthentication": { | ||
| "functionName": "PostAuthentication", | ||
| "description": "Logs user authentication events to S3" | ||
| } | ||
| } | ||
| }, | ||
| "storage": { | ||
| "buckets": [ | ||
| { | ||
| "name": "fitnessappstorage", | ||
| "access": ["auth", "guest"], | ||
| "cors": { | ||
| "allowedOrigins": ["*"], | ||
| "allowedMethods": ["GET", "POST", "PUT", "DELETE"], | ||
| "allowedHeaders": ["*"], | ||
| "maxAge": 3000 | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "function": { | ||
| "functions": [ | ||
| { | ||
| "name": "quotegenerator", | ||
| "runtime": "nodejs", | ||
| "template": "hello-world", | ||
| "handler": "index.handler", | ||
| "description": "Generates motivational fitness quotes" | ||
| }, | ||
| { | ||
| "name": "PostAuthentication", | ||
| "runtime": "nodejs", | ||
| "template": "trigger", | ||
| "handler": "index.handler", | ||
| "description": "Cognito post-authentication trigger for logging user activity", | ||
| "permissions": [ | ||
| "s3:PutObject", | ||
| "s3:GetObject" | ||
| ], | ||
| "environment": { | ||
| "STORAGE_FITNESSAPPSTORAGE_BUCKETNAME": "fitnessappbucket" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "hosting": { | ||
| "type": "amplify-console", | ||
| "buildSettings": { | ||
| "buildCommand": "npm run build", | ||
| "outputDirectory": "dist", | ||
| "nodeVersion": "25" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "app": { | ||
| "name": "discussions", | ||
| "description": "Discussion app with phone authentication and activity logging" | ||
| }, | ||
| "categories": { | ||
| "api": { | ||
| "type": "GraphQL", | ||
| "schema": "schema.graphql", | ||
| "authModes": ["API_KEY", "COGNITO_USER_POOLS"], | ||
| "customQueries": ["getUserActivity"], | ||
| "customMutations": ["logActivity"] | ||
| }, | ||
| "auth": { | ||
| "signInMethods": ["phone"], | ||
| "socialProviders": [] | ||
| }, | ||
| "storage": { | ||
| "buckets": [ | ||
| { | ||
| "name": "countsTable", | ||
| "access": ["auth"] | ||
| } | ||
| ] | ||
| }, | ||
| "function": { | ||
| "functions": [ | ||
| { | ||
| "name": "activityLogger", | ||
| "runtime": "nodejs", | ||
| "template": "hello-world" | ||
| } | ||
| ] | ||
| }, | ||
| "hosting": { | ||
| "type": "amplify-console" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "app": { | ||
| "name": "media-vault", | ||
| "description": "Personal media vault with social authentication and thumbnail generation" | ||
| }, | ||
| "categories": { | ||
| "api": { | ||
| "type": "GraphQL", | ||
| "schema": "schema.graphql", | ||
| "authModes": ["COGNITO_USER_POOLS", "API_KEY"] | ||
| }, | ||
| "auth": { | ||
| "signInMethods": ["email", "phone"], | ||
| "socialProviders": ["facebook", "google"] | ||
| }, | ||
| "storage": { | ||
| "buckets": [ | ||
| { | ||
| "name": "media", | ||
| "access": ["auth", "guest"] | ||
| } | ||
| ] | ||
| }, | ||
| "function": { | ||
| "functions": [ | ||
| { | ||
| "name": "thumbnailgen", | ||
| "runtime": "nodejs", | ||
| "template": "hello-world" | ||
| } | ||
| ] | ||
| }, | ||
| "hosting": { | ||
| "type": "amplify-console" | ||
| } | ||
| } | ||
| } |
39 changes: 39 additions & 0 deletions
39
amplify-migration-apps/product-catalog/migration-config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "app": { | ||
| "name": "app-1", | ||
| "description": "Product catalog with role-based authentication and inventory management", | ||
| "framework": "react" | ||
| }, | ||
| "categories": { | ||
| "api": { | ||
| "type": "GraphQL", | ||
| "schema": "schema.graphql", | ||
| "authModes": ["IAM", "API_KEY", "COGNITO_USER_POOLS"], | ||
| "customQueries": ["checkLowStock"] | ||
| }, | ||
| "auth": { | ||
| "signInMethods": ["email"], | ||
| "socialProviders": [] | ||
| }, | ||
| "storage": { | ||
| "buckets": [ | ||
| { | ||
| "name": "productimages3bucket", | ||
| "access": ["auth"] | ||
| } | ||
| ] | ||
| }, | ||
| "function": { | ||
| "functions": [ | ||
| { | ||
| "name": "lowstockproductcatalog", | ||
| "runtime": "nodejs", | ||
| "template": "hello-world" | ||
| } | ||
| ] | ||
| }, | ||
| "hosting": { | ||
| "type": "amplify-console" | ||
| } | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
amplify-migration-apps/project-boards/migration-config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "app": { | ||
| "name": "project-boards", | ||
| "description": "Project board app with authentication and file storage", | ||
| "framework": "react" | ||
| }, | ||
| "categories": { | ||
| "api": { | ||
| "type": "GraphQL", | ||
| "schema": "schema.graphql", | ||
| "authModes": ["API_KEY", "COGNITO_USER_POOLS"] | ||
| }, | ||
| "auth": { | ||
| "signInMethods": ["email"], | ||
| "socialProviders": [] | ||
| }, | ||
| "storage": { | ||
| "buckets": [ | ||
| { | ||
| "name": "images", | ||
| "access": ["auth", "guest"] | ||
| } | ||
| ] | ||
| }, | ||
| "function": { | ||
| "functions": [ | ||
| { | ||
| "name": "quotegenerator", | ||
| "runtime": "nodejs", | ||
| "template": "hello-world" | ||
| } | ||
| ] | ||
| }, | ||
| "hosting": { | ||
| "type": "amplify-console" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was as bug in the original code, that was unused. Sending profile name in this way did not select the expected profile, as it is not a typed input. It is only a selection via up/down arrow keys.