Fix YAML native parameters and tags #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue: value} object list
…s but we can still pass YAML object via strings, so updating the documentation to reflect that
…ue: value} object list
…s but we can still pass YAML object via strings, so updating the documentation to reflect that
- Add Real-time Event Streaming section with feature overview - Document enable-event-streaming input parameter with examples - Include sample event output showing color-coded status indicators - Update permissions to include cloudformation:DescribeStackEvents - Enhance example workflow with event streaming configuration - Remove unnecessary Python linters from Trunk configuration The event streaming feature provides AWS Console-like visibility directly in GitHub Actions logs with real-time monitoring, color-coded status, and detailed error messages.
- Add prominent notifications when no updates are needed for deployment - Display clear messages: '✅ No updates to deploy - CloudFormation stack is already up to date' - Improve event streaming to detect and notify when no changes occur - Add 30-second buffer to event filtering to prevent showing historical events - Implement smart detection that stops event streaming after 10 polls with no events - Add comprehensive test coverage with 10 new test cases for notification scenarios - Handle edge cases like undefined stack names and special characters - Maintain backward compatibility with existing deployment flows Fixes issue where users saw confusing historical events from previous deployments when running with no-fail-on-empty-changeset=1 and no actual changes to deploy.
…dding deployment summary - Handle 'Stack does not exist' errors gracefully during initial polling - Return empty array instead of throwing error for expected condition - Add deployment summary display when terminal events are detected - Improve terminal event detection to only check main stack resource type - Show meaningful final status (DEPLOYMENT_COMPLETE/DEPLOYMENT_FAILED/NO_CHANGES) - Update integration tests to match new behavior - Maintain 98%+ test coverage Fixes misleading warning at deployment start and missing summary at completion.
- Fixed ExtractedError import in event-streaming-coverage.test.ts - Added comprehensive tests for uncovered edge cases: - Empty changeset detection (no events scenario) - Final status logging for no events - Throttling backoff calculation - NO_CHANGES final status handling - Achieved 98.9% statement coverage and 99.03% line coverage - All tests now pass with coverage thresholds met Resolves event streaming UX issues: - Duplicate deployment summaries prevented - JSON errors properly converted to YAML format - Empty changeset scenarios handled gracefully - Improved error handling and edge case coverage
- Improved branch coverage from 88.67% to 93.77% - Added tests for AWS error detection edge cases - Added tests for non-Error object handling in error detection - Added tests for event sorting with missing timestamps - Added tests for progressive backoff calculation scenarios - Added tests for DEPLOYMENT_COMPLETE final status handling - Added tests for normal completion with summary display Final coverage results: - Statements: 99.52% (exceeds 98% threshold) - Lines: 99.51% (exceeds 98% threshold) - Branches: 93.77% (exceeds 90% threshold) - Functions: 100% (meets 100% threshold) All coverage thresholds now comfortably exceeded with comprehensive edge case testing that improves production reliability.
Enabling Cloud Formation stack event to be pushed back to github action
Correcet permissions in github actions
Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #151:
Description of changes:
As GitHub Actions are in YAML this PR allow the user to use parameter-overrides and tags with naive YAML.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.