Skip to content

Conversation

@FreddosaurusRex
Copy link

hi I just changed the implementation of fizzbuzz in go a little bit.
using an empty string and then appending Fizz/Buzz to it, and printing th eoutput at the end. also I removed printing out the # if it wasn't fizzbuzz

@jcxldn
Copy link
Contributor

jcxldn commented Oct 28, 2018

If the number isn't Fizz/Buzz/FizzBuzz, then you want to just output the number.
Feel free to make that change, and then I'll be happy to merge your changes.

You are correct in that a better way to do it is to append to a string, but you also need to output the number if it wasn't fizzbuzz.

@FreddosaurusRex

@jcxldn jcxldn added waiting awaiting review add2readme Pull Requests that need to add their code to the README. and removed awaiting review labels Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add2readme Pull Requests that need to add their code to the README. awaiting review type: go waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants