Make room name comparison case agnostic#47
Make room name comparison case agnostic#47ChefdeCambuse wants to merge 2 commits intoavstack:masterfrom
Conversation
…arison Make room name comparison case agnostic
|
This isn’t the only transformation Jitsi Meet does, it converts PascalCase titles to kebab-case localparts. Additionally, localparts comparisons after stringprep are case insensitive so your operation is a noop. |
In what situation does it do that? I haven't seen it do that. Anyway, there is indeed a problem here, because we compare as a string, so the room name comparison fails if |
|
Hi, since !200 and !204 there is now a |
The main change is that jid now stores the JID as a single string, with an offset to the '@' and to the '/', and stringprep is now always applied. This lowers the size of the struct in memory, and makes it much faster to display a JID. In order to also make it fast to run stringprep, there are new NodePart, DomainPart and ResourcePart types which are guaranteed to have been validated/normalized, and thus can be used to construct a JID at the cost of a format!() call. In lib-gst-meet in particular, this removes quite a bunch of clone() calls, but nothing significant. Supersedes avstack#47.
When providing the room name as shown by Jitsi - e.g. "DarkSignsMobilizeExpectantly" - gst-meet will connect to the room but never proceed as the response(s) to send_presence contain the room name in lower case.