Disable pseudo-terminal allocation for the rsync copy backend

[pevogam]

In cases of hanging aexpect processes it is possible that we exhaust the pseudo-terminals on the system. Disabling pseudo-terminal allocation for the rsync backend should help mitigate this issue.

Summary by CodeRabbit

• Bug Fixes

  • Updated SSH configuration in remote file synchronization operations.

• Documentation

  • Revised remote file transfer examples to reflect current practices.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@pevogam has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 23 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between cd2fa1d and e8f368d.

📒 Files selected for processing (2)

• aexpect/remote.py
• tests/test_remote.py

Walkthrough

The pull request modifies the SSH command options in aexpect/remote.py across three locations: the remote_copy docstring example, the rsync_to_remote function, and the rsync_from_remote function. The change replaces the SSH port option from "-p" to "-Tp" in each occurrence. No control flow, error handling, or functional logic is altered by these changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Disable pseudo-terminal allocation for the rsync copy backend' accurately describes the main change: replacing SSH option '-p' with '-Tp' disables pseudo-terminal allocation in rsync commands.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ldoktor]

Thanks, should be better to use -T for rsync anyway. I have tested it with interactive password and it seemed to work well as well (I was afraid it might not work).