Skip to content

Conversation

@dependabot-preview
Copy link

Bumps actionview from 5.2.3 to 6.0.2.2. This update includes a security fix.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Possible XSS vulnerability in ActionView There is a possible XSS vulnerability in ActionView's JavaScript literal escape helpers. Views that use the j or escape_javascript methods may be susceptible to XSS attacks.

Versions Affected: All. Not affected: None. Fixed Versions: 6.0.2.2, 5.2.4.2

Impact

There is a possible XSS vulnerability in the j and escape_javascript methods in ActionView. These methods are used for escaping JavaScript string literals. Impacted code will look something like this:

<script>let a = `<%= j unknown_input %>`</script>

or

... (truncated)

Patched versions: ~> 5.2.4, >= 5.2.4.2; >= 6.0.2.2 Unaffected versions: none

Release notes

Sourced from actionview's releases.

6.0.2.1

Active Support

  • No changes.

Active Model

  • No changes.

Active Record

  • No changes.

Action View

  • No changes.

Action Pack

  • Fix possible information leak / session hijacking vulnerability.

    The ActionDispatch::Session::MemcacheStore is still vulnerable given it requires the gem dalli to be updated as well.

    CVE-2019-16782.

Active Job

  • No changes.

Action Mailer

  • No changes.

Action Cable

... (truncated)
Changelog

Sourced from actionview's changelog.

Rails 6.0.2.1 (December 18, 2019)

  • No changes.

Rails 6.0.2 (December 13, 2019)

  • No changes.

Rails 6.0.1 (November 5, 2019)

  • UJS avoids Element.closest() for IE 9 compatibility.

    George Claghorn

Rails 6.0.0 (August 16, 2019)

  • ActionView::Helpers::SanitizeHelper: support rails-html-sanitizer 1.1.0.

    Juanito Fatas

Rails 6.0.0.rc2 (July 22, 2019)

  • Fix select_tag so that it doesn't change options when include_blank is present.

    Younes SERRAJ

Rails 6.0.0.rc1 (April 24, 2019)

  • Fix partial caching skips same item issue

    If we render cached collection partials with repeated items, those repeated items will get skipped. For example, if you have 5 identical items in your collection, Rails only renders the first one when cached is set to true. But it should render all 5 items instead.

    Fixes #35114.

    Stan Lo

  • Only clear ActionView cache in development on file changes

    To speed up development mode, view caches are only cleared when files in the view paths have changed. Applications which have implemented custom ActionView::Resolver subclasses may need to add their own cache clearing.

... (truncated)
Commits
  • 157920a Preparing for 6.0.2.2 release
  • 1251d88 Fix possible XSS vector in JS escape helper
  • f33d52c Preparing for 6.0.2.1 release
  • f675cb3 Preparing for 6.0.2 release
  • 63107e9 Preparing for 6.0.2.rc2 release
  • ec7721c Revert "Merge pull request #37504 from utilum/no_implicit_conversion_of_nil"
  • a015f55 Preparing for 6.0.2.rc1 release
  • 7bb5b66 [ci skip] Document deprecations for TemplateHandler subclasses
  • 824ca84 [ci skip] Document changes for render(file: ) behaviour
  • f2dfc5a Merge branch '6-0-1' into 6-0-stable
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [actionview](https://github.com/rails/rails) from 5.2.3 to 6.0.2.2. **This update includes a security fix.**
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.0.2.2/actionview/CHANGELOG.md)
- [Commits](rails/rails@v5.2.3...v6.0.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Security related issues labels Mar 19, 2020
@dependabot-preview
Copy link
Author

Dependabot tried to add @ervalhous as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/autoforce/APIcasso/pulls/116/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the autoforce/APIcasso repository. // See: https://developer.github.com/v3/pulls/review_requests/#create-a-review-request

@codecov-io
Copy link

codecov-io commented Mar 19, 2020

Codecov Report

Merging #116 into master will decrease coverage by 85.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #116      +/-   ##
=========================================
- Coverage   96.99%   11.4%   -85.6%     
=========================================
  Files          24      15       -9     
  Lines         931     614     -317     
=========================================
- Hits          903      70     -833     
- Misses         28     544     +516
Impacted Files Coverage Δ
spec/requests/singularized/requests_spec.rb 1.87% <0%> (-97.5%) ⬇️
...equests/plurarized/requests_with_plurarize_spec.rb 1.87% <0%> (-97.5%) ⬇️
spec/token/token_spec.rb 4.23% <0%> (-95.77%) ⬇️
spec/requests/batch_spec.rb 6.12% <0%> (-93.88%) ⬇️
spec/requests/singularized/bad_requests_spec.rb 12.5% <0%> (-87.5%) ⬇️
...sts/plurarized/bad_requests_with_plurarize_spec.rb 12.5% <0%> (-87.5%) ⬇️
spec/models/used_model_spec.rb 41.17% <0%> (-58.83%) ⬇️
app/models/apicasso/key.rb 63.63% <0%> (-36.37%) ⬇️
spec/apicasso_spec.rb 66.66% <0%> (-33.34%) ⬇️
spec/dummy/app/models/used_model.rb 46.15% <0%> (-15.39%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95b5fc...d15476e. Read the comment docs.

@dependabot-preview
Copy link
Author

Superseded by #122.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/actionview-6.0.2.2 branch May 7, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file security Security related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants