test: add more tests #614
Merged
test: add more tests #614
+389
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miparnisari
force-pushed
the
more-tests
branch
2 times, most recently
from
4673d5e to
eb72a81
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 41.35% 42.04% +0.69%
==========================================
Files 38 38
Lines 4998 5018 +20
==========================================
+ Hits 2067 2110 +43
+ Misses 2684 2654 -30
- Partials 247 254 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
commented
Dec 29, 2025
|
|
||
| func schemaDiffCmdFunc(_ *cobra.Command, args []string) error { | ||
| beforeBytes, err := os.ReadFile(args[0]) | ||
| beforeReader, err := os.Open(args[0]) |
Contributor
Author
There was a problem hiding this comment.
refactor for testability
miparnisari
commented
Dec 29, 2025
| return nil | ||
| } | ||
|
|
||
| func schemaCopyInner(ctx context.Context, srcClient, destClient v1.SchemaServiceClient, definitionPrefix string) (*v1.WriteSchemaResponse, error) { |
Contributor
Author
There was a problem hiding this comment.
refactor for testability
miparnisari
commented
Dec 29, 2025
| } | ||
| } | ||
|
|
||
| type mockWriteSchemaClient struct { |
Contributor
Author
There was a problem hiding this comment.
replaced by the auto-generated mock
miparnisari
force-pushed
the
more-tests
branch
from
eb72a81 to
e871b10
Compare
miparnisari
force-pushed
the
more-tests
branch
from
e871b10 to
26d6ca8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing code coverage of
schema.go. No change in functionality.