refactor: backupCreate for testability#604
Merged
miparnisari merged 1 commit intoauthzed:mainfrom Mar 31, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 42.33% 43.03% +0.69%
==========================================
Files 38 38
Lines 6113 6098 -15
==========================================
+ Hits 2588 2624 +36
+ Misses 3264 3208 -56
- Partials 261 266 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ivanauth
force-pushed
the
fix/issue-569-refactor-backup-create
branch
from
8437759 to
7a02c9f
Compare
Contributor
can you explain this? i don't think we should remove support for serverless yet |
ivanauth
force-pushed
the
fix/issue-569-refactor-backup-create
branch
from
46fc10a to
c0f705f
Compare
Contributor
Author
|
You're right, removing serverless support is a separate decision. Reworked PR. |
ivanauth
force-pushed
the
fix/issue-569-refactor-backup-create
branch
2 times, most recently
from
6bc52b3 to
58c3d78
Compare
miparnisari
changed the title
miparnisari
force-pushed
the
fix/issue-569-refactor-backup-create
branch
from
58c3d78 to
d4003ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backupCreateImplwith injectable client andProgressTrackerinterface for testabilityRemove legacy Serverless backup path--prefix-filterand--rewrite-legacyflagsResolves #569