Feat: Bind origin domain cookie to state parameter #223
Merged
kailash-b merged 2 commits intojava-mvc-v2from May 8, 2026
Merged
Feat: Bind origin domain cookie to state parameter #223kailash-b merged 2 commits intojava-mvc-v2from
kailash-b merged 2 commits intojava-mvc-v2from
Conversation
Contributor
Author
|
@copilot Please review the PR |
Reviewed the PR. Here's a summary:
Tests
No issues found — the implementation correctly binds the origin domain cookie to the transaction's state parameter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
stateparameter in its signature:HMAC(domain|state, secret)domainProvider.getDomain()sign(value, context, secret)andverifyAndExtract(signedValue, context, secret)overloads toSignedCookieUtils