feat: add Deploy CLI support for ACR authorization_policy on Auth0 My…#1381
Open
ankita10119 wants to merge 2 commits intomasterfrom
Open
feat: add Deploy CLI support for ACR authorization_policy on Auth0 My…#1381ankita10119 wants to merge 2 commits intomasterfrom
ankita10119 wants to merge 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1381 +/- ##
=======================================
Coverage 79.85% 79.85%
=======================================
Files 153 153
Lines 7023 7023
Branches 1537 1537
=======================================
Hits 5608 5608
Misses 780 780
Partials 635 635 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
please add
In pr description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Add Deploy CLI support for ACR
authorization_policyon Auth0 My Account API resource server.authorization_policyto theallowedKeyslist ingetType()so the field is preserved when exporting the My Account API (previously stripped silently, causing the next import to always attempt to clear it)authorization_policyto the hard-coded update payload inupdateResourceServer()so the field is included in PATCH calls for system resource servers (previously never sent, making it impossible to set or clear via Deploy CLI)📚 References
🔬 Testing
Three new unit tests added to
test/tools/auth0/handlers/resourceServers.tests.js:should preserve authorization_policy on system resource server export (getType)- verifies field is not stripped on exportshould include authorization_policy in update payload for Auth0 My Account API- verifies field is sent in PATCH body when setting a policyshould include authorization_policy: null in update payload for Auth0 My Account API- verifiesnullis passed through correctly to clear the policy📝 Checklist