Fix: a0deploy keyword replacement mappings not applied to theme.json #1379
Open
ankita10119 wants to merge 1 commit intomasterfrom
Open
Fix: a0deploy keyword replacement mappings not applied to theme.json #1379ankita10119 wants to merge 1 commit intomasterfrom
ankita10119 wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
=======================================
Coverage 79.85% 79.85%
=======================================
Files 153 153
Lines 7023 7023
Branches 1537 1537
=======================================
Hits 5608 5608
Misses 780 780
Partials 635 635 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kushalshit27
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this fix, keyword placeholder substitution (e.g.
##CDN_URL##) was silently skipped for theme assets during export. The root cause was that ThemesHandler did not declare an identifiers array, so the keyword-preservation logic - which uses identifiers to build dot-notation lookup paths for each array item - found no matching fields and returned the raw resolved remote URLs instead of preserving the original placeholders.🔧 Changes
Added
identifiers: ['themeId']to the DefaultHandler options in ThemesHandler, aligning it with how other handlers expose their identifier field so that getPreservableFieldsFromAssets can correctly locate each theme record.🔬 Testing
New unit tests added under describe('#themes keyword preservation') in test/tools/auth0/handlers/themes.tests.js:
##CDN_URL##) in nested theme fields (fonts.font_url, widget.logo_url) are preserved after export.📝 Checklist