[HOTFIX] #56 페이지별 테마설정 이슈 #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
상단 window status bar에도 적용하면 좋을거 같아요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
상세 화면에서는 DaangnTheme가 아닌 DaangnBlackTheme가 적용되어야 하는데, 적용이 안되있던 문제 수정
🛠 To Do
🍿 수정방법
DetailScreen의 가장 상단에는 Box Component가 위치합니다.
Box Component인 경우 DaangnPhotoApp에서 지정한 DaangnPhotoTheme가 적용되게 됩니다.😭
이 때문에 DaangnBlackTheme가 아닌 DaangnTheme가 적용되었으며,
이를 수정하기 위해 Box Component를 content color를 지정할 수 있는 Surface로 한번 더 감싸게 되었습니다.
🪴 결과 화면
👇🏻 Light Theme에서도 Dark Theme로 보이는 상세 화면
KakaoTalk_Video_2023-03-07-11-55-59.mp4
🏠 관련 Issue
Closed #56