Add all vanilla dye colors to wires (1.21.1)#432
Open
Sol-Low wants to merge 3 commits into
Open
Conversation
Sol-Low
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the 9 missing dye colors (orange, lime, light blue, cyan, purple, magenta, pink, light gray, gray) to all four colored wire types: insulated, highly insulated, ceramic, and logistical bringing all wire types to full parity with vanilla dye colors
Fixes broken imports in SubtypeWire.java that shadowed the correct SoundType, Color, and Tags types with Mekanism/JEI equivalents, causing 33 compile errors
Replaces the 345-line manual wire lang entry block in ElectrodynamicsLangKeyProvider with a loop over SubtypeWire.values(), so new wire variants are automatically covered by datagen with no future manual additions needed.
p.s. I was bilnd and didnt realize I was trying to PR without a fork lmao, thanks for your hard work and patience!
<3
-Sol-Low