fix(mobile): take-control auto-enables control mode#94
Merged
Conversation
The viewer overlay's "接管控制 / Take control" button only claimed driver at the relay level — it didn't flip the local controlMode toggle in the control panel below. Users tapped Take control, saw the overlay disappear, then nothing worked until they ALSO toggled the bottom-bar checkbox. The two-gate flow was confusing in practice. Set controlMode = true inside takeControl(). The toggle stays visible and operable so users who want to lock input mid-session (e.g. scroll back without firing keystrokes via accidental taps) can disable it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro
On mobile, when the desktop is driver and the phone is viewer, tapping "接管控制" (Take control) hides the overlay but doesn't actually enable input — the user has to additionally toggle the 控制模式 (Control mode) checkbox at the bottom of the control panel for any key/quick-text/paste button to do anything.
Two gates with the same intent → confusing.
Fix
Set `controlMode.value = true` inside `takeControl()`. The control-mode toggle stays visible and operable so users who want to lock input mid-session (e.g. scroll back without firing keystrokes from accidental taps on the keyboard bar) can still disable it again.
`isDriver` (relay-level write lock) and `controlMode` (local input safety gate) remain separate concepts; this PR just removes the double-tap-to-be-useful UX.
Test plan