This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Convert Directory and File classes to JavaScript#1226
Merged
Conversation
Contributor
|
I considered doing this too but I wondered if it'd totally break a bunch of pending PRs. Is there anything we absolutely want to merge before doing this? |
Contributor
Author
|
@daviwil Thanks for bringing that up. I've identified the following PRs that also modify one of the files changed in this PR: Therefore I believe the ones we should look at and potentially merge before this one are #1144 and #1048. It looks like @lee-dohm is already helping with #1048, which only leaves #1144. |
Contributor
winstliu
force-pushed
the
wl-directory-file-js
branch
from
c874d9b to
089acd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Converts the Directory and File-related classes to JavaScript. I plan on investigating switching tree-view over to
@atom/watcher, which the JavaScript conversion will help with.Alternate Designs
None.
Benefits
JavaScript!
Possible Drawbacks
Potential regressions. I'd like to think that spec coverage is pretty good for tree-view but I'll be using this branch for a while before merging to play it extra safe.
Applicable Issues
None.