This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
This was referenced Nov 15, 2017
winstliu
force-pushed
the
wl-right-click-correctly
branch
from
eabd725 to
4ee4fbe
Compare
darangi
force-pushed
the
wl-right-click-correctly
branch
from
4ee4fbe to
55168b6
Compare
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Add context menu commands to all tabs and use the resulting
event.elementproperty to figure out the path to execute the command on. This makes right-clicking a better experience and is helpful for atom/atom#16192.Alternate Designs
None.
Benefits
All tabs will have Rename and Show in commands.
Possible Drawbacks
None.
Applicable Issues
Fixes atom/atom#13617
Refs atom/atom#16191