Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@kmilov
Copy link

@kmilov kmilov commented Apr 9, 2015

There is a conflict with the ctrl+M key map when the user have the Emmet package installed.
This change will prevent the error. also, the Keybinding resolver doesn't support the comma operator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the data attributes instead and keep targeting the element instead of the class.

atom-workspace atom-text-editor:not([mini])

See https://github.com/atom/atom/blob/74a627d41b41ce39e0a5ad43a08dbd4ce2a46fcc/keymaps/darwin.cson#L139 for an example

@kevgathuku
Copy link

@kmilov @kevinsawicki Mind if I take this on? This is still an issue for me when I have both the emmet and markdown-preview packages installed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants