Skip to content

Decaffeinate#2

Draft
aminya wants to merge 21 commits intomasterfrom
decaffeinate
Draft

Decaffeinate#2
aminya wants to merge 21 commits intomasterfrom
decaffeinate

Conversation

@aminya
Copy link
Copy Markdown
Member

@aminya aminya commented Jul 10, 2020

No description provided.

@aminya aminya marked this pull request as draft July 10, 2020 13:05
@aminya aminya force-pushed the decaffeinate branch 3 times, most recently from 7e0831e to 72328a3 Compare July 13, 2020 02:14
aminya added 9 commits July 12, 2020 23:52
@aminya
feat: use CoffeeScript 1
04c6f52
@aminya
chore: atom and mixto types
246705e
@aminya
Update package-lock.json
a0e158f
@aminya
test: require from lib/atom-utils
f9d4cee
@aminya
feat: atom-utils
b431265 
- import/export
- default export compat
- remove excess returns
- use => instead of function
@aminya
feat: ancestors
1d83bdc 
- import/export
- optional chaining
- shorter null check
- eachParent is void function
@aminya
feat: disposable-events import/export
7ba2ed7
@aminya
feat: events-delegation
6263bf2 
- optional chaining
- import/export
- using intiClass to simulate CoffeeScript behavior
- remove excess implicit returns
- shorter null checks
- remove excess Array.from
@aminya
feat: register-or-update-element
13a17dc 
- using optional chaining
- using functions/lambdas
- dynamic import grim to speed up loading
- formatting
aminya added 3 commits July 13, 2020 00:00
@aminya
feat: space-pen-dsl
65f93a1 
- import/export
- using initClass to replace CoffeeScript behavior
- remove excess Array.from
- optional chaining
- remove excess return
@aminya
chore: remove coffee files
a615fd4
@aminya
feat: using coffee file for space-pen-dsl
38fefcf
@aminya
Copy link
Copy Markdown
Member Author

aminya commented Jul 13, 2020

The space-pen-dsl.js file does not work properly yet, and so I included the original coffee file. CoffeeScript 1 compiles classes to functions (instead of a class) which is not the same as compiling it to a class. We should update mixto as well to a class to make this work.

@aminya
Copy link
Copy Markdown
Member Author

aminya commented Jul 28, 2020

Now atom/mixto supports ES6 classes: atom/mixto#2 🎉

We need to adjust the code in space-pen-dsl so the useShadowRoot and _use_shadowRoot_ get defined correctly. We should use defineProperty instead of assigning.

@aminya aminya mentioned this pull request Nov 21, 2020
Merged
@aminya aminya closed this Jul 22, 2021
@aminya aminya closed this Jul 22, 2021
@aminya aminya reopened this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aminya